Page 1 of 1

Not dead yet, commit 134

PostPosted: Mon Jul 08, 2013 11:04 pm
by sairuk
Been hell crook of late but not dead yet.

Put up commit 134 last night which improves the fuzzy artwork matching, thanks to a bug report by Brian Murphy. I would like some feedback on this particularly with the data set I used in developing the regex pattern. Is there any naming convention in the test data below I haven't considered? (Just noticed the [BIOS] Tiger Game.com is trimmed to far, that is because there is no file extension present in the test data, so that is something that still needs improving)

https://bugs.launchpad.net/wahcade/+bug/1172584


REGEX: ((\.[^\.]+$)|(\s\(.+(?<=(\)|\]|\s))\.[^\.]+$))

TEST DATA:
=========================================================
Alcazar - The Forgotten Fortress (1985) (Activision).rom
BABYBLU3_00528_01.zip
1942 The Pacific Air War (1994)(Microprose Software Inc)(Rev1).zip
Arcade Minor Emus - [RAW]men (v0.83) - mslug5.zip
duckhunt.zip
[GBA] Tony Hawk's Pro Skater 2 (Retail) (U).zip
[BIOS] Tiger Game.com (USA) (Internal)
a.something.ext
Atari PAM Diagnostics (USA) (v2.3).zip
A.C.U. Docs 01 - 08 Revisited (1991)(A.C.U.)(Disk 3 of 3).zip
CD-Boot v1.0 (19xx)(Amiga Legal Emulation)(PD).zip
Kickstart v1.2 r33.180 (1986)(Commodore)(A500-A1000-A2000)[!].zip
Kickstart v1.2 r33.180 (1986)(Commodore)(A500-A1000-A2000)[!] .zip

RESULTS:
=========================================================
Alcazar - The Forgotten Fortress
BABYBLU3_00528_01
1942 The Pacific Air War
Arcade Minor Emus - [RAW]men (v0.83) - mslug5
duckhunt
[GBA] Tony Hawk's Pro Skater 2
[BIOS] Tiger Game
a.something
Atari PAM Diagnostics
A.C.U. Docs 01 - 08 Revisited
CD-Boot v1.0
Kickstart v1.2 r33.180
Kickstart v1.2 r33.180

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 4:58 am
by Zombie
I'm going to test this as soon as I can, reason being, I have problems with Fuzzy artwork where I KNOW the file name is dead on correct, but because it contains one character or another, you don't see anything at all. By the way, Can I get you to look at some of my other idea threads?

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 6:54 am
by Zombie
Found a Crash. :)

Code: Select all
Traceback (most recent call last):
  File "/usr/share/games/wahcade/joystick.py", line 201, in poll
    event_cb(active_window, e, "JOYSTICK", mw_key)
  File "/usr/share/games/wahcade/win_main.py", line 619, in on_winMain_key_press
    self.sclGames.update()
  File "/usr/share/games/wahcade/scrolled_list.py", line 97, in update
    self.signals['update'](self._ls_idx)
  File "/usr/share/games/wahcade/win_main.py", line 922, in on_sclGames_changed
    (i + 1))
  File "/usr/share/games/wahcade/wc_common.py", line 201, in get_artwork_image
    IMAGE_FILETYPES)
  File "/usr/share/games/wahcade/wc_common.py", line 148, in get_matching_filename
    f = re.search(p,fn)
  File "/usr/lib64/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
  File "/usr/lib64/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
error: bad character range

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 11:57 am
by sairuk
do you know what filename this crash happened on?

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 4:22 pm
by Zombie
Traceback (most recent call last):
File "/usr/share/games/wahcade/joystick.py", line 169, in poll
if self.devices[dev_num].get_button(int(button_num)):
error: Invalid joystick button

Here's another error, this hapens when there is a joypad with insuffiecent buttons connected to the machine. (i.e. A Button the program wants doesn't exist.)

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 4:26 pm
by Zombie
Another error, this happens when there is a joypad with insuffiecent buttons connected to the machine. (i.e. A Button the program wants doesn't exist.)
Code: Select all
Traceback (most recent call last):
  File "/usr/share/games/wahcade/joystick.py", line 169, in poll
    if self.devices[dev_num].get_button(int(button_num)):
error: Invalid joystick button


Code: Select all
Traceback (most recent call last):
  File "/usr/share/games/wahcade/win_main.py", line 724, in on_winMain_key_press
    self.load_emulator(emu_list[emu_idx])
  File "/usr/share/games/wahcade/win_main.py", line 1320, in load_emulator
    self.load_list()
  File "/usr/share/games/wahcade/win_main.py", line 1364, in load_list
    self.pop_games_list()
  File "/usr/share/games/wahcade/win_main.py", line 1684, in pop_games_list
    self.on_sclGames_changed()
  File "/usr/share/games/wahcade/win_main.py", line 922, in on_sclGames_changed
    (i + 1))
  File "/usr/share/games/wahcade/wc_common.py", line 201, in get_artwork_image
    IMAGE_FILETYPES)
  File "/usr/share/games/wahcade/wc_common.py", line 148, in get_matching_filename
    f = re.search(p,fn)
  File "/usr/lib64/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
  File "/usr/lib64/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
error: bad character range


with wahcade -d:

Code: Select all
Traceback (most recent call last):
  File "/usr/share/games/wahcade/win_main.py", line 619, in on_winMain_key_press
    self.sclGames.update()
  File "/usr/share/games/wahcade/scrolled_list.py", line 97, in update
    self.signals['update'](self._ls_idx)
  File "/usr/share/games/wahcade/win_main.py", line 922, in on_sclGames_changed
    (i + 1))
  File "/usr/share/games/wahcade/wc_common.py", line 201, in get_artwork_image
    IMAGE_FILETYPES)
  File "/usr/share/games/wahcade/wc_common.py", line 148, in get_matching_filename
    f = re.search(p,fn)
  File "/usr/lib64/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
  File "/usr/lib64/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
sre_constants.error: bad character range


These happened as I was scrolling through Genesis roms.

Re: Not dead yet, commit 134

PostPosted: Tue Jul 09, 2013 10:50 pm
by sairuk
What version where you using before you moved to commit 134? The only thing changed between 133 <> 134 was the regex.

What naming convention is applied to the genesis rom set? Good/No-Intro/Random?

Re: Not dead yet, commit 134

PostPosted: Wed Jul 10, 2013 4:26 am
by Zombie
They were GoodRoms files. Known good dumps. All the Sonic Games cause this.

Re: Not dead yet, commit 134

PostPosted: Wed Jul 10, 2013 12:21 pm
by sairuk
Zombie wrote:They were GoodRoms files. Known good dumps. All the Sonic Games cause this.


Have a go of 136, that should fix the fuzzy artwork issue you were having. I was able to simulate it here and fix it locally and another problem capturing strange filenames. There errors should now be captured: error: bad character range & error: unbalanced parenthesis

goodgen_results.csv



NB: i will not be looking into the controller swapping issue at this point in time, i cannot simulate that here. If not already please add it to launchpad

Re: Not dead yet, commit 134

PostPosted: Thu Jul 11, 2013 5:30 am
by Zombie
The issue seems cleared up for revision 136 with a few interesting side effects. in some cases, the Fuzzy artwork search paints with "too broad a Brush". in the past, you could have B.O.B with no image no matter what commit you used. Here, sometimes Earthworm Jim Art shows up for Earthworm Jim 2.

Re: Not dead yet, commit 134

PostPosted: Fri Jul 12, 2013 1:54 pm
by General_Faliure
Good to see you are still at it.
I am setting up a new(er) mainboard for my cab, but at the moment i have verry little time.
The mainboard is now sitting on a testbench running lubuntu/mahcade/mame, i still have to set up some more emulators.
Keep up the good work.